Fix: skip-github-release silently skipped tag creation too#12
Merged
Conversation
PR #10 merged 0.2.0's manifest/changelog bump, but no v0.2.0 tag ever got created or pushed - skip-github-release turned out to skip the underlying git tag as well, not just the GitHub Release object (googleapis/release-please-action#1034). Since release.yml only triggers on a tag push, this silently broke both the git release and the actual NuGet publish for 0.2.0. Replaced skip-github-release with draft: true instead: release-please still creates the tag (restoring the trigger chain) plus a draft (not publicly visible) GitHub Release. release.yml's publish job now explicitly un-drafts that same release (draft: false) only after a successful, approved NuGet push, rather than creating a second one - softprops/action-gh-release updates an existing release for a tag rather than failing or duplicating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
PR #10 merged 0.2.0's manifest/changelog bump, but no v0.2.0 tag ever
got created or pushed - skip-github-release turned out to skip the
underlying git tag as well, not just the GitHub Release object
(googleapis/release-please-action#1034). Since release.yml only
triggers on a tag push, this silently broke both the git release and
the actual NuGet publish for 0.2.0.
Replaced skip-github-release with draft: true instead: release-please
still creates the tag (restoring the trigger chain) plus a draft
(not publicly visible) GitHub Release. release.yml's publish job now
explicitly un-drafts that same release (draft: false) only after a
successful, approved NuGet push, rather than creating a second one -
softprops/action-gh-release updates an existing release for a tag
rather than failing or duplicating.
Checklist
dotnet test)dotnet format --verify-no-changespassesCHANGELOG.mdupdated under[Unreleased]docs/COMPATIBILITY.mdupdated for any endpoint you implemented or changed